-
Notifications
You must be signed in to change notification settings - Fork 15
Revision of Cate's Data Management #153
Comments
Looks good. One note. When using a 'PolygonLike' from new types, one has to keep in mind that what one can get might be whatever valid polygon. Then, it depends on what OpenDAP can do, but probably a bounding box has to be extracted and used for selection. One question though is what to do with values that are in the bounding box, but not part of the polygon. In the 'subset_spatial' operation I plan to mask these with NaN. I'm not sure what would be the best approach upon opening - mask with NaN, create a 'mask' variable, or just select the bounding box. |
Yepp!
Please make this an optional behavior. e.g. use new kwarg |
Hi Norman,
|
… instead of Tuple[datetime,datetime]
… type instead of GeometryLike (too general for region selection), fixed minor issues in region calculation
… instead of Tuple[datetime,datetime] (part 2)
…RangeLike instead of Tuple[datetime,datetime] (ESA ODP DataSource)
#153 AppVeyor build fix, mocked ODP datastore query which tries to access esfg service
…ed verification if all needed attributes exists
…ed verification if all needed attributes exists
#153 added make local and delete local to CLI
We need a slight revision of Cate's Data Management, especially a revised
cate.core.ds.DataSource
interface. Details are here:https://github.com/CCI-Tools/cate-core/wiki/Revision-of-Cate's-Data-Management
DataSource.open_dataset
API, add more constraint args, deprecateprotocol
arg, use new types, generalise towards any return type (forman)DataSource.make_local
API (forman)open_dataset
overrides wrt deprecateprotocol
arg and support new constraint params (kbernat)make_local
overrides, reuse oldsync
method and Chris' new code (kbernat)open_dataset
constraint args in CLI + GUI (forman)make_local
in favor ofsync
where appropriate. We might keep private_sync
method as an implementation detail (forman, kbernat)cate.core.ds
andcate.ds
code coverage by unit-tests (kbernat)The text was updated successfully, but these errors were encountered: