Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offsets can be tracked via thing ID #5

Open
C0urante opened this issue Dec 1, 2019 · 0 comments
Open

Offsets can be tracked via thing ID #5

C0urante opened this issue Dec 1, 2019 · 0 comments

Comments

@C0urante
Copy link
Owner

C0urante commented Dec 1, 2019

The IDs reddit associates with its threads and comments are monotonically increasing base 36 numbers; these should be used to store offset information instead of timestamp since two posts/comments can potentially be made at the same time.
This should be implemented carefully to preserve backwards compatibility. Offsets should still be written with submission timestamps and the connector should still support filtering messages based on timestamp in to allow for a rolling upgrade of the connector. However, it should give priority to IDs in offsets if it finds them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant