Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mis-matched/ambiguous Units on Process Conditions #403

Open
c-heat16 opened this issue Nov 2, 2023 · 1 comment
Open

Mis-matched/ambiguous Units on Process Conditions #403

c-heat16 opened this issue Nov 2, 2023 · 1 comment

Comments

@c-heat16
Copy link

c-heat16 commented Nov 2, 2023

Describe the bug
When adding a temperature condition with units of degrees Kelvin, the CRIPT editor displays both 'degC' and 'kelvin' after the numerical value of the temperature. Units for 'time_duration' and 'flow rate' condition are displayed correctly.

To Reproduce
Steps to reproduce the behavior:

Add a temperature condition to a process as described below, and save.

temp = cript.Condition(
    key='temperature', value=530, unit='kelvin', type='none'
)
process.condition += [temp]

Expected behavior
Units associated with temperature condition to be shown accurately without ambiguity.

Screenshots
Ambiguous reaction temp units:
Screen Shot 2023-11-02 at 5 55 50 PM

Accurate time duration/flow rate:
Screen Shot 2023-11-02 at 6 01 11 PM
Screen Shot 2023-11-02 at 6 01 47 PM

Time duration/flow rate created via:

time = cript.Condition(
    key='time_duration', value=2, unit='min', type='none'
)
process.condition += [time]

helium_flow_rate = cript.Condition(
    key='flow_rate', value=150, unit='mL/min', type='none',
    descriptor='µ-Pyr Column flow = 0.76 ML/min'
)
process.condition += [helium_flow_rate]
@c-heat16
Copy link
Author

c-heat16 commented Nov 2, 2023

Somewhat related, I also noticed sub-optimal presentation of material quantities. The quantity listed below is 1e-7 kg, but the combination of all the decimal places plus the up/down arrows obscure the real quantity. At a glance, it looks like the material has a quantity of 1kg

Screen Shot 2023-11-02 at 6 18 15 PM
Screen Shot 2023-11-02 at 6 18 27 PM

@C-Accel-CRIPT C-Accel-CRIPT deleted a comment from nh916 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants