-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm32 support #52
wasm32 support #52
Conversation
Thanks a lot, much appreciated! Could you share how I would test that? The answer to this question could lead to an update to the CI workflow to (possibly) allow testing this functionality, or to add documentation in the README, but at least I'd like to test it locally, somehow, but lack experience with the WASM workflow. Thanks again for your help. |
Good question. I pull in bevy and trunk to test it but probably one of
trunk’s examples can be a lot smaller. Let me have a look how to at least
make it easy to manual test.
…On Sun, 4 Sept 2022 at 08:04, Sebastian Thiel ***@***.***> wrote:
Thanks a lot, much appreciated!
Could you share how I would test that? The answer to this question could
lead to an update to the CI workflow to (possibly) allow testing this
functionality, or to add documentation in the README, but at least I'd like
to test it locally, somehow, but lack experience with the WASM workflow.
Thanks again for your help.
—
Reply to this email directly, view it on GitHub
<#52 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEJCCIZNTGKYR3L2NASGTV4RCWPANCNFSM6AAAAAAQD2MFXE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
While this works for FF and Chrome, on iOS and Safari this appears as a pop-up window and is blocked by default rather than being a new tab. |
Thanks for the update. A large example would also be appreciated - maybe you can share the patch to apply to the |
There's a snag with the current implementation, it doesn't quite do what it says on the tin. Safari/iOS blocks popups by default so it seems like nothing happens. |
Maybe it's possible to give the user a choice and have JS decide if it should attempt a tab or change the URL of the current window instead. Hardcoding browser specifics seems like a well-intended step that can backfire as browsers change their rules or implementation. Maybe it's possible to learn from other crates as well - there is |
Opening the link in the same window will work every time so maybe we should
do that.
…On Mon, 14 Nov 2022 at 13:26, Sebastian Thiel ***@***.***> wrote:
Maybe it's possible to give the user a choice and have JS decide if it
should attempt a tab or change the URL of the current window instead.
Hardcoding browser specifics seems like a well-intended step that can
backfire as browsers change their rules or implementation.
Maybe it's possible to learn from other crates as well - there is opener
<https://crates.io/crates/opener> for example which seems to be more
popular and maybe does a few things right (while not having been updated
for a year).
—
Reply to this email directly, view it on GitHub
<#52 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEJCAT6BDSKWKLZBJDALTWII4XTANCNFSM6AAAAAAQD2MFXE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That's true, but in general I find this behaviour problematic as it's not semantically the same as what happens if It looks like What about providing a new function that indicates these semantic differences and provides the option to try opening in a new tab, explaining that this might not work depending on the browser you are in or the users extensions. |
Closing due to inactivity. Please feel free to rebase against |
Does what it says on the tin. Opens a new tab with the given url. ( Fixes #49 )