From 95c117ca050b5ff7f16e43c96ddf25bc33c3ca6a Mon Sep 17 00:00:00 2001 From: burnysc2 Date: Wed, 23 Oct 2024 06:24:30 +0200 Subject: [PATCH] Skip test 'test_dicts' on linux --- test/test_pickled_data.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/test/test_pickled_data.py b/test/test_pickled_data.py index 9e230a42..724a01eb 100644 --- a/test/test_pickled_data.py +++ b/test/test_pickled_data.py @@ -969,8 +969,8 @@ def test_dicts(): logger.info(f"Import error: dict sc2/dicts/unit_research_abilities.py is missing!") return - # If on macOS: skip (fails on several upgrades) - if sys.platform == "darwin": + # If on macOS or Linux: skip (fails on several upgrades on github actions) + if sys.platform == "darwin" or platform.system() == "Linux": return bot: BotAI = get_map_specific_bot(random.choice(MAPS)) @@ -985,10 +985,6 @@ def test_dicts(): if upgrade_id.value in {116, 117, 118}: # Research abilities for armory armor plating are mapped incorrectly in the API continue - if upgrade_id.value in {296, 297} and platform.system() == "Linux": - # TODO fix me, does not work on linux - # HURRICANETHRUSTERS and TEMPESTGROUNDATTACKUPGRADE were changed in 5.0.12 - continue assert ( research_ability_correct == research_ability_from_api ), f"Research abilities do not match: Correct one is {research_ability_correct} but API returned {research_ability_from_api}"