-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve experience when symbolic links are not searched #460
Comments
It sounds like you're asking for symbolic links that were skipped to appear in the output of --debug? Would that resolve things for you?
I don't understand the issue here. Could you say more and also say how you expect it to be solved? Printing files that were skipped by default is a non-starter IMO. |
What I meant was - sometimes you search, sometimes there is no output, but in your mind, there should have been. Most likely it's user error, but it could be a bug in ripgrep. Either way, I want help understanding what happened. Ultimately I'm suggesting that ripgrep should provide an option to explain what was skipped and why so that I, as a user, can understand exactly what was and wasn't searched. This definitely can't be a default - there would be too much noise. The explanation should include the why if possible - filter, .gitignore, sym link, binary, others? |
@lzybkr Right, OK. That is indeed the problem I was trying to solve with the output in I don't think it can ever be quite perfect. For example, if you know there is a match in the file |
I think I'm going to close this because I'm not sure what the concrete steps would be to satisfy this request. Additionally, I kind of feel like "the tool doesn't follow symlinks by default but has a flag to enable it" is pretty standard for command line tools (e.g., |
Today, there is an inconsistent experience around symbolic links.
If no files are searched (e.g. you are in a directory that only contains symbolic links), you get an error message suggesting
--debug
, but that doesn't help.If at least 1 file is searched, you get no output even if you should have.
If no files are searched, it might be worth adding some text to the error suggesting
-L
or--follow
.If some files are searched, it might be nice to have some way of listing which files/directories were skipped - e.g. because they were links, binary files, excluded by .gitignore, hidden, or whatever.
The text was updated successfully, but these errors were encountered: