Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memchr<'_> is no longer Sync from v2.6 #133

Closed
Nugine opened this issue Aug 30, 2023 · 2 comments
Closed

Memchr<'_> is no longer Sync from v2.6 #133

Nugine opened this issue Aug 30, 2023 · 2 comments

Comments

@Nugine
Copy link

Nugine commented Aug 30, 2023

Test code:

use memchr::memchr_iter;

pub fn assert_sync<T: Sync>(_: &T) {}

pub fn foo(input: &[u8]) {
    assert_sync(&memchr_iter(b'\n', input));
}

See also Nugine/s3s#79

@marregui
Copy link

I am thinking this fix deserves a t-shirt

@BurntSushi
Copy link
Owner

This is fixed on crates.io in memchr 2.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants