Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified: #307 issue #309

Closed
rabdulatif opened this issue Oct 4, 2024 · 2 comments
Closed

Modified: #307 issue #309

rabdulatif opened this issue Oct 4, 2024 · 2 comments
Assignees

Comments

@rabdulatif
Copy link
Contributor

            => (route is not null && !route.DownstreamScheme.IsNullOrEmpty())
                ? route.DownstreamScheme
                : !service.Scheme.IsNullOrEmpty()
                    ? service.Scheme
                    : service.DownstreamPort
                        switch
                        {
                            443 => Uri.UriSchemeHttps,
                            80 => Uri.UriSchemeHttp,
                            _ => conf?.Scheme ?? "http",
                        }; ```
                        
   i've made change in GetScheme method instead of init **builder.Scheme** in if block.
   And this code now passing  **UseCorrectSchemeByPort** Test. If you prefer can change it.
   Or i can make a PR
                        
                      
@Burgyn
Copy link
Owner

Burgyn commented Oct 4, 2024

released in 8.3.2

@Burgyn Burgyn closed this as completed Oct 4, 2024
@rabdulatif
Copy link
Contributor Author

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants