Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.AddOcelotWithSwaggerSupport reloadOnChange files #234

Closed
naji-makhoul opened this issue Aug 2, 2022 · 5 comments
Closed

config.AddOcelotWithSwaggerSupport reloadOnChange files #234

naji-makhoul opened this issue Aug 2, 2022 · 5 comments
Labels
waiting-8-days Closing after 8 days of waiting for the additional info requested.

Comments

@naji-makhoul
Copy link

reloadOnChange file when use AddOcelotWithSwaggerSupport

config.AddOcelotWithSwaggerSupport((o) => {
                  o.Folder = "OcelotConfiguration";                   
            }).AddEnvironmentVariables();

like when add json file :

config.AddJsonFile($"ocelot.{hostingContext.HostingEnvironment.EnvironmentName}.json", optional: false, reloadOnChange: true)
                     .AddEnvironmentVariables();
@Burgyn
Copy link
Owner

Burgyn commented Aug 2, 2022

Hi,
thank you for your issue.

Unfortunately, you didn't write much. I cannot judge whether it is a question, a comment, a request, ...

Could you please be more specific? Try to describe current behavior, expected behavior, ... Ideally, add an example.

@naji-makhoul
Copy link
Author

Hi .
i need to reload ocelot file when the file is changes on runtime without restart the app

when i set the ocelot config files with AddOcelotWithSwaggerSupport and change the routes in the file its not updated on runtime

when i use AddJsonFile with reloadOnChange = true , its updated

@Burgyn
Copy link
Owner

Burgyn commented Aug 2, 2022

Hi,

which version do you use? This was fix in version 5.2.0 (PR #230)

@Burgyn Burgyn added the waiting-8-days Closing after 8 days of waiting for the additional info requested. label Aug 2, 2022
@naji-makhoul
Copy link
Author

I use version 4.9.0 , I will update and check it again, thank you

@github-actions github-actions bot removed the waiting-8-days Closing after 8 days of waiting for the additional info requested. label Aug 3, 2022
@Burgyn Burgyn added the waiting-8-days Closing after 8 days of waiting for the additional info requested. label Aug 9, 2022
@github-actions
Copy link

Closing after 8 days of waiting for the additional info requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-8-days Closing after 8 days of waiting for the additional info requested.
Projects
None yet
Development

No branches or pull requests

2 participants