Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate API help on ocelot gateway doesn't show help for nested model #12

Closed
amit1980in opened this issue Feb 4, 2019 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amit1980in
Copy link

Individual API is showing swagger help for nested model, however nested model is not shown in ocelot API gateway swagger help. our model definitions is like below

public class SavingActuals
{
public double Comfort { get; set; }
public double Energy { get; set; }
public double RealEstate { get; set; }
}

public class DetailedChartSavingData
{
    public string Group { get; set; }
    public double Projection { get; set; }
    public double Target { get; set; }
    public SavingActuals Actual { get; set; }
}

SavingActuals is not rendered on swagger page present on ocelot gateway. however it is shown when I am looking individual service swagger.

@Burgyn Burgyn added the bug Something isn't working label Feb 4, 2019
@Burgyn
Copy link
Owner

Burgyn commented Feb 5, 2019

Hi, thanks for your report.

Can you please provide downstream service swagger.json and ocelot configuration?

@Burgyn Burgyn pinned this issue Feb 5, 2019
@Burgyn Burgyn added this to the Version 1.0.1 milestone Feb 5, 2019
@Burgyn Burgyn self-assigned this Feb 5, 2019
@amit1980in
Copy link
Author

downstreamswagger.txt
OcelotSwagger.txt

I have attached downstream microservice and ocelot response of swagger json. In individual service you will see SavingActuals model is present but not present in ocelot

@Burgyn
Copy link
Owner

Burgyn commented Feb 5, 2019

Thanks, but can you attached ocelot reroutes configuration? I want investigate where is a problem.

@amit1980in
Copy link
Author

configuration.Development.txt
adding routes

@amit1980in
Copy link
Author

look for financial api swagger

@Burgyn
Copy link
Owner

Burgyn commented Feb 5, 2019

This bug was fixed in PR #15 and will by published as new version of package 1.0.1 soon.

Thanks for collaboration.

@Burgyn Burgyn closed this as completed Feb 5, 2019
@Burgyn Burgyn unpinned this issue Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants