Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Dynamic FPS #108

Open
LostLuma opened this issue Sep 28, 2023 · 5 comments · May be fixed by #109
Open

Incompatible with Dynamic FPS #108

LostLuma opened this issue Sep 28, 2023 · 5 comments · May be fixed by #109
Labels
bug Something isn't working

Comments

@LostLuma
Copy link

LostLuma commented Sep 28, 2023

What went wrong?

Using Dynamic FPS and FastLoad together causes the world loading screen to stay open forever.
I've explained the reason in the original report, and will create a PR with a fix for this issue shortly.

Reproduction steps

  • Install Dynamic FPS and FastLoad
  • Attempt to join a Minecraft world

Visual demonstration

https://files.lostluma.net/UJ1pWH.png

Crash Report & Log

unneeded

Fastload Config

Default Config

Environment

Dynamic FPS 3.2.0
FastLoad 3.4.0

@justjustjustjust
Copy link

justjustjustjust commented Dec 30, 2023

Yeeeep, came here exactly beacuse of this reason. Installed the fix and everything is PERFECT now. ty

@LostLuma
Copy link
Author

Note that as of Dynamic FPS 3.4.2 if Fastload 3.4.0 or earlier is present we fix this on our side, but if this mod ever gets updated again the PR should be merged before the next release.

@KirboSoftware
Copy link

@LostLuma is this still the case to this day?

@LostLuma
Copy link
Author

LostLuma commented May 23, 2024

Yes. We ship the fix for Minecraft 1.20.4 and lower (since FastLoad is not available and not useful in 1.20.5+, and the background blur instead of dirt texture also means we no longer have this optimization).

@KirboSoftware
Copy link

Alright, I will take a look at #109 and implement it on the multiloader version 👍 since I think this affects all affect loaders that we support currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants