Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks the progress of the rework of the scrolling system. The goal here is to update it so that we can have custom actions for scrolling in the future and to generally make the code cleaner.
The goal here is to try and create a new
ScrollView
that uses our configuration of key bindings. We can then create more custom actions for any scroll view that can be configurable.Because the
ArticleView
needs access to the scroll core, we need to separate the event logic and theScrollView
itself, so that theArticleView
can implement the scroller itself while every other view can be wrapped in our customScrollView