Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Scrolling System #164

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Rework the Scrolling System #164

merged 5 commits into from
Mar 9, 2023

Conversation

Builditluc
Copy link
Owner

@Builditluc Builditluc commented Mar 7, 2023

This tracks the progress of the rework of the scrolling system. The goal here is to update it so that we can have custom actions for scrolling in the future and to generally make the code cleaner.

The goal here is to try and create a new ScrollView that uses our configuration of key bindings. We can then create more custom actions for any scroll view that can be configurable.

Because the ArticleView needs access to the scroll core, we need to separate the event logic and the ScrollView itself, so that the ArticleView can implement the scroller itself while every other view can be wrapped in our custom ScrollView

@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project labels Mar 7, 2023
@Builditluc Builditluc self-assigned this Mar 7, 2023
@Builditluc Builditluc marked this pull request as ready for review March 9, 2023 06:12
@Builditluc Builditluc merged commit d305698 into main Mar 9, 2023
@Builditluc Builditluc deleted the rework-scrolling branch March 9, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant