Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] can't disable logging #90

Closed
2 tasks done
nunotexbsd opened this issue Nov 3, 2022 · 1 comment · Fixed by #91
Closed
2 tasks done

[BUG] can't disable logging #90

nunotexbsd opened this issue Nov 3, 2022 · 1 comment · Fixed by #91
Labels
state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version

Comments

@nunotexbsd
Copy link
Contributor

General Information
Version: 0.5.1
Installation Method: source
Operating System: FreeBSD

Describe the bug
~/.config/wiki-tui/config.toml:

[logging]
enabled = false
log_dir = 'wiki_tui.log'
log_level = 'INFO'

log is created.

Checklist

  • checked other issues for the same bug
  • read CONTRIBUTING.md
@nunotexbsd nunotexbsd added the bug label Nov 3, 2022
@Builditluc Builditluc linked a pull request Nov 4, 2022 that will close this issue
Disable logging if not enabled in the config #91
Merged
@Builditluc
Copy link
Owner

Thank you for your bug report!
I've created a patch that fixes this issue (the logfile won't be created now if logging is disabled) and made a PR. It'll be available in the next release!

@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version labels Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable logging if not enabled in the config Builditluc/wiki-tui
2 participants
@Builditluc @nunotexbsd