Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] URL encoded links yield error when open them from the page #179

Closed
2 tasks done
non-descriptive opened this issue May 26, 2023 · 3 comments · Fixed by #181
Closed
2 tasks done

[BUG] URL encoded links yield error when open them from the page #179

non-descriptive opened this issue May 26, 2023 · 3 comments · Fixed by #181
Assignees
Labels
bug-type: parser This bug is related to the parser (for example, incorrect lists or missing elements in the article) state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version

Comments

@non-descriptive
Copy link

General Information
Version: 0.7.0
Installation Method: cargo
Operating System: any
Backend (If changed during install): default

Describe the bug
URLs made of ASCII characters and for languages, that lies outside of the ASCII range (like Cyrilic languges, Japaneese or Chineese, Arabic etc) UTF text encoded as escape codes. For some reason this kindof links fails to concatenate with the main url and yield error about empty title of the page. Also when redirect message pop-up appears it displays URL encoded mess like (%D0%A0%D0%B0%D1%81%D1%82%D0%B8%D1%82%D0%B5%D0%BB%D1%8C%D0%BD%D0%BE%D0%B5_%D0%BC%D0%BE%D0%BB%D0%BE%D0%BA%D0%BE).
We can decode it and display readable text to the user.

To Reproduce
Steps to reproduce the behavior:

  1. Switch search language to esperanto
  2. Search "Censerey" and open first result.
  3. Navigate to the third link on the page " Côte-d'Or"
  4. Attempt to go to the page
  5. See encoded link
    image
  6. Confirm opening
  7. See error
    image

Expected behavior
Page should be opened like if we searched.
Search results doesn't share faulty behaviour when searching and opening non-ascii links.

Additional context
Log : wiki-tui.log

Checklist

  • checked other issues for the same bug
  • read CONTRIBUTING.md
@non-descriptive non-descriptive added the type: bug This fixes a bug. Increment the minor version label May 26, 2023
@non-descriptive non-descriptive changed the title [BUG] URL encoded links yield error [BUG] URL encoded links yield error when open them from the page May 26, 2023
@Builditluc
Copy link
Owner

Thank you for your bug report @non-descriptive! I've already reproduced it and am now trying to get to the root of the issue

@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on bug-type: ui This bug is ui related bug-type: parser This bug is related to the parser (for example, incorrect lists or missing elements in the article) and removed bug-type: ui This bug is ui related labels May 27, 2023
@Builditluc Builditluc self-assigned this May 27, 2023
@Builditluc
Copy link
Owner

Good news! The issue should be fixed in the fix-url-decoding branch. Could you maybe check if it fixed the issue for you as well?

@non-descriptive
Copy link
Author

Confirm that fix is working.

@Builditluc Builditluc linked a pull request May 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-type: parser This bug is related to the parser (for example, incorrect lists or missing elements in the article) state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants