Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] URI fragments don't get handled properly #112

Closed
2 tasks done
Builditluc opened this issue Dec 24, 2022 · 1 comment · Fixed by #192
Closed
2 tasks done

[BUG] URI fragments don't get handled properly #112

Builditluc opened this issue Dec 24, 2022 · 1 comment · Fixed by #192
Labels
state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version

Comments

@Builditluc
Copy link
Owner

General Information
Version: 0.6.0
Installation Method: cargo
Operating System: macOS
Backend (If changed during install): default

Describe the bug
When the target URL of a link contains an URI fragment, it doesn't get handled nicely by the opening dialog (it is left in its raw form, see the screenshot below) and when opening said article, it stays at the top of the article and doesn't scroll to the required position.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Atom (text editor) wiki page in wiki-tui
  2. Scroll down to the link unique UUID v4 random identifier (it is almost at the bottom of the article)
  3. Open said link

Expected behavior
The user should be informed by the dialog box that the link is pointing to a specific position in the article and the program should scroll down to said position when opening the article.

Screenshots
image

Checklist

  • checked other issues for the same bug
  • read CONTRIBUTING.md
@Builditluc Builditluc added the bug label Dec 24, 2022
@Builditluc Builditluc added type: bug This fixes a bug. Increment the minor version state: approved This issue or pull request was approved and can be worked on state: blocked This issue cannot be worked on until others have been finished and removed bug state: approved This issue or pull request was approved and can be worked on labels Dec 31, 2022
@Builditluc
Copy link
Owner Author

Blocking this issue because the following issues have to be completed first:

@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on and removed state: blocked This issue cannot be worked on until others have been finished labels Jan 8, 2023
@Builditluc Builditluc moved this from Todo to In Development in wiki-tui: Roadmap May 21, 2023
@Builditluc Builditluc moved this from In Development to Todo in wiki-tui: Roadmap Jun 19, 2023
@Anaphylaxis Anaphylaxis mentioned this issue Jun 22, 2023
Closed
@Builditluc Builditluc moved this from Todo to In Development in wiki-tui: Roadmap Aug 2, 2023
@Builditluc Builditluc mentioned this issue Aug 2, 2023
Merged
@Builditluc Builditluc linked a pull request Aug 2, 2023 that will close this issue
Notify on links with an Anchor #192
Merged
@github-project-automation github-project-automation bot moved this from In Development to Done in wiki-tui: Roadmap Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: approved This issue or pull request was approved and can be worked on type: bug This fixes a bug. Increment the minor version
Projects
wiki-tui: Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notify on links with an Anchor Builditluc/wiki-tui
1 participant
@Builditluc