Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - accessibility - when you tab to submit search icon screenreaders read out 'blank' #178

Closed
Dan-KeduTesting opened this issue Sep 30, 2019 · 3 comments

Comments

@Dan-KeduTesting
Copy link

see screenshot for code with issue.

i guess its because the "submit search" text is within a span, does it need to be in a span?

@enginehouse
Copy link
Contributor

@Dan-KeduTesting it uses a generic icon generator component for consistency so comes wrapped in a span - I can take it out though if it is causing trouble

@Dan-KeduTesting
Copy link
Author

Dan-KeduTesting commented Sep 30, 2019

yeah please take it out

by the way, its also an issue on homepage search textbox button and search page textbox button

@enginehouse

@Dan-KeduTesting
Copy link
Author

this is still an issue. it now contains no text within the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants