Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does socket.io's Node v4 build issues impact browser-sync? #820

Closed
fkling opened this issue Sep 16, 2015 · 2 comments
Closed

Does socket.io's Node v4 build issues impact browser-sync? #820

fkling opened this issue Sep 16, 2015 · 2 comments

Comments

@fkling
Copy link

fkling commented Sep 16, 2015

This comment claims that browser-sync works fine on Node v4, however, there are build errors with the current socket.io version on npm (v1.3.6) and Node v4, which can also be found in the CI log.

But given that the tests seem to pass fine, can I expect browser-sync to work even if there are build errors during install?

See also websockets/utf-8-validate#13, which points out the issues with socket.io.

@shinnn
Copy link
Contributor

shinnn commented Sep 16, 2015

The errors arise only on optional deps build and they don't stop browser-sync working. https://github.com/websockets/ws/blob/0.7.2/package.json#L28-L29

@shinnn shinnn closed this as completed Sep 16, 2015
@fkling
Copy link
Author

fkling commented Sep 16, 2015

Ah, should have looked in the package.json. Thanks for the clarification! Those errors do look scarry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants