Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-sync package not installing with yarn #1475

Open
romanmarkelov opened this issue Dec 28, 2017 · 7 comments
Open

browser-sync package not installing with yarn #1475

romanmarkelov opened this issue Dec 28, 2017 · 7 comments

Comments

@romanmarkelov
Copy link

romanmarkelov commented Dec 28, 2017

Issue details

browser-sync package not installing with yarn

Steps to reproduce/test case

yarn add browser-sync

Please specify which version of Browsersync, node and npm you're running

  • Browsersync [2.22.0]
  • Node [9.3.0]
  • Npm [5.6.0]
  • Yarn [1.3.2]

Affected platforms

  • [10.12.6 ] OS X

Open same issue in yarn repository

@dmbdesignpdx
Copy link

I, too, am having the same problem. Also with updating.

  • Node: 8.9.3
  • Browser-Sync: 2.23.1
  • Yarn: 1.3.2
  • macOS: 10.13.2

When running yarn upgrade browser-sync and after removing, then running yarn add -D browser-sync, I got this both times:

[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
⠁ 
⠁ 
[1/2] ⠂ fsevents
[-/2] ⠈ waiting...
[-/2] ⢀ waiting...
[-/2] ⠈ waiting...
[2/2] ⠈ uws
[-/2] ⠈ waiting...
[-/2] ⠈ waiting...
[4/4] 📃  Building fresh packages...
[-/2] ⠁ waiting...
[2/2] ⠁ uws
[-/2] ⠁ waiting...
[-/2] ⠁ waiting...
[-/2] ⠁ waiting...

@jonnitto
Copy link

jonnitto commented Jan 1, 2018

The same here. It works until version 2.19.0. Any version higher it doesn't work anymore.

@dmbdesignpdx
Copy link

Update:
I can't add any new packages without this issue happening and it appears to revolve around Browser-Sync:

  • Removing Browser-Sync allows me to install new packages without a problem
  • Reverting to an older version of Browser-Sync (2.18.3) also allows me to install new packages without a problem

@oviava
Copy link

oviava commented Jan 19, 2018

@dmbdesignpdx try this yarnpkg/yarn#5131 (comment).

@dmbdesignpdx
Copy link

After great patience, digging, and input from the Yarn team; there may be a simple fix. This issue might have to do with uws being out-of-sync with node-gyp.

Reinstall/install node-gyp by running npm install -g node-gyp and see if that takes care of it.

@shakyShane
Copy link
Contributor

shakyShane commented Feb 13, 2018

thanks for the update @dmbdesignpdx - it's a shame this has happened in the first place, and i'm seriously considering moving away from socket.io because of this.

I absolutely detest packages that require building in the environment they are installed - I understand why, but every time I've ever included such a package it's resulted in these types of issues :(

I believe uws is used when perf is an absolute must - but in reality Browsersync does not need screaming performance, no-where near in fact.

@romanmarkelov
Copy link
Author

romanmarkelov commented Feb 28, 2018

I upgraded yarn to 1.5.1. today and browser-sync installed without mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants