Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle config file path rename gracefully #902

Closed
yezr opened this issue Nov 14, 2024 · 0 comments · Fixed by #903
Closed

Handle config file path rename gracefully #902

yezr opened this issue Nov 14, 2024 · 0 comments · Fixed by #903
Assignees

Comments

@yezr
Copy link
Collaborator

yezr commented Nov 14, 2024

RCTab Version: 1.3.999

What Happened

Saved a config file w/ some configuration options. Outside of RCTab, renamed the folder that the config file was in. Afterwards, back in RCTab, it seemed like anything that required a file picker wasn't working as expected

  • I was unable to add new CVR. The "Select .xlsx" button clicked but no file selector showed up.
  • I was also unable to save config to a different place. Clicking File -> Save seemed to do nothing, with no file picker showing up.
  • I was unable to change the output location.

In each of these examples, the console did log some Java exceptions but no messages in the RCTab app logger.

Going to File -> Load does show an error, but clicking 'Don't Save' or 'Save' doesn't do anything. Cancel will close the modal. The error shows once per click of File -> Load. In this screenshot I clicked it twice.
image

What I Expect to Happen

If the expected location of the .config file doesn't exist I would expect it to be treated like a newly configured RCTab that hasn't had a .config saved or loaded yet.

Open Questions

  • Any type of warning logged when we notice that the expected location doesn't exist anymore?
@yezr yezr added the needs-rcvrc-clarification where RCVRC input could help clarify development tasks label Nov 14, 2024
@yezr yezr added this to RCTab v2.0 Nov 14, 2024
@artoonie artoonie self-assigned this Nov 18, 2024
@yezr yezr removed the needs-rcvrc-clarification where RCVRC input could help clarify development tasks label Dec 30, 2024
@yezr yezr moved this to Todo in RCTab v2.0 Dec 30, 2024
@artoonie artoonie moved this from Todo to In Review in RCTab v2.0 Dec 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in RCTab v2.0 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants