Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a more elegant way to get the file path of results files and their expected counterparts during testing #897

Open
yezr opened this issue Oct 30, 2024 · 1 comment

Comments

@yezr
Copy link
Collaborator

yezr commented Oct 30, 2024

More than one comment on #894 felt that the OutputFileIdentifiers class not having enough information at its instantiation to know the ultimate file path of the on disk files should be addressed. It seems like this is related to the expectation in the tests that the expected results to check against are located at the same path but with an "expected" modifier in the file name.

Can we think of an elegant way to address both of these?

@yezr yezr added this to RCTab v2.0 Oct 30, 2024
@yezr
Copy link
Collaborator Author

yezr commented Oct 30, 2024

Set to not in scope for 2.0

@yezr yezr changed the title Find a more elegant way to ge the file path of results files and their expected counterparts during testing Find a more elegant way to get the file path of results files and their expected counterparts during testing Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant