Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK and all other deps for v2.0.0 #669

Open
HEdingfield opened this issue May 23, 2023 · 6 comments · Fixed by #722 · May be fixed by #877
Open

Update JDK and all other deps for v2.0.0 #669

HEdingfield opened this issue May 23, 2023 · 6 comments · Fixed by #722 · May be fixed by #877
Assignees

Comments

@HEdingfield
Copy link
Contributor

No description provided.

@HEdingfield HEdingfield converted this from a draft issue May 23, 2023
@HEdingfield HEdingfield self-assigned this May 23, 2023
@HEdingfield
Copy link
Contributor Author

@artoonie are you ok with me upgrading from JDK 17 to 20 in the next week or two (along with all the other deps), or would that be disruptive to your workflow?

@artoonie
Copy link
Collaborator

Won't be disruptive to me -- go for it!

@HEdingfield
Copy link
Contributor Author

Address this warning that's been popping up as well:

The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead. See https://docs.gradle.org/7.5.1/dsl/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:main for more details.

@HEdingfield HEdingfield moved this from Todo to In Progress in RCTab v2.0 Jun 12, 2023
@HEdingfield
Copy link
Contributor Author

Possibly relevant: When building on GH like this, this message appears:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-java@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@HEdingfield
Copy link
Contributor Author

@tarheel @artoonie recommend grabbing JDK 20.0.1 from here and getting that going in IntelliJ.

@HEdingfield HEdingfield moved this from In Progress to In Review in RCTab v2.0 Jun 26, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in RCTab v2.0 Jun 27, 2023
@HEdingfield
Copy link
Contributor Author

Re-opening this since JDK / deps will surely have new versions by the time we actually get 1.4.0 released.

@HEdingfield HEdingfield reopened this Oct 28, 2023
@HEdingfield HEdingfield moved this from Done to Todo in RCTab v2.0 Oct 28, 2023
@yezr yezr changed the title Update JDK and all other deps for v1.4.0 Update JDK and all other deps for v2.0.0 Feb 20, 2024
@nurse-the-code nurse-the-code linked a pull request Aug 15, 2024 that will close this issue
@yezr yezr linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants