Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After selecting UI audit log line, losing focus makes it difficult to read #838

Closed
yezr opened this issue Jun 6, 2024 · 2 comments · Fixed by #842
Closed

After selecting UI audit log line, losing focus makes it difficult to read #838

yezr opened this issue Jun 6, 2024 · 2 comments · Fixed by #842

Comments

@yezr
Copy link
Collaborator

yezr commented Jun 6, 2024

RCTab Version 1.3.999

What Happens

After #832 users can select line by line in the UI audit log. When clicked, a line becomes highlighted. Error audit log lines are highlighted in red, regular audit log lines are highlighted in a light blue. However, when you have a line selected and then click outside of the audit log that text in that line goes grey and becomes difficult to read.
ui log highlights

What should happen

We should either keep the highlight/text with visible contrast or remove highlighting of lines all together.

@HEdingfield
Copy link
Contributor

From this PR thread:

It feels weird to me to have the lines highlighted when I click on them. It's also almost unreadable when you click a severe line then click above in the GUI so it loses focus.

I'd recommend disabling highlighting (or maybe just make it a trace outline). If you're set on keeping it, at least make clicking outside the pane remove the highlighting completely instead of setting it to a weird neutral color.

The difficulty in reading particular occurs for SEVERE and WARNING logs.

@artoonie artoonie moved this from Todo to In Progress in RCTab v2.0 Jun 9, 2024
@artoonie artoonie moved this from In Progress to In Review in RCTab v2.0 Jun 10, 2024
@yezr yezr linked a pull request Jun 12, 2024 that will close this issue
@yezr
Copy link
Collaborator Author

yezr commented Jun 12, 2024

fixed with #842

@yezr yezr closed this as completed Jun 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in RCTab v2.0 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants