Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a cross-tool method of standardizing version numbers #662

Open
artoonie opened this issue Apr 26, 2023 · 2 comments
Open

Find a cross-tool method of standardizing version numbers #662

artoonie opened this issue Apr 26, 2023 · 2 comments

Comments

@artoonie
Copy link
Collaborator

artoonie commented Apr 26, 2023

Currently (after Issue #57 / PR #660), the version number needs to be synced in three places:

  1. Main.java
  2. build.gradle
  3. release.yml

Figure out a way to have just one place to update. Note the issues with version tagging: we prefer Main.java to allow version tags (e.g. -alpha), but jpackage on some platforms (at least Windows) will not allow non-canonical version numbers. It must be in the format a.b.c, not a.b.c-alpha. Figure out a solution. Some ideas:

  1. Perhaps we use 0.0.0 as version numbers in builds?
  2. Perhaps we no longer use -alpha?
  3. Perhaps we use -alpha and accept that `jpackage will fail, and argue that this is okay because we don't want nicely packaged development builds that could be confused with official releases, especially if they have the same version number?

(I lean towards 3 or 1.)

@HEdingfield
Copy link
Contributor

I think this was actually after issue #57 / PR #660?

Thanks for researching this! I definitely like option 3 best, since we shouldn't bother doing jpackage builds for alpha versions anyway, like you mentioned (the whole alpha thing is really just a CYA convention we put in place in case someone demands a mid-cycle build for some purpose, in which case we can just give them the jlinkZip output).

@HEdingfield HEdingfield moved this to Todo in RCTab v2.0 May 21, 2023
@HEdingfield HEdingfield self-assigned this May 31, 2023
@HEdingfield
Copy link
Contributor

More discussion about this issue in #719 (comment).

Barring an easy win here, it may be sufficient to just note all the spots in the release instructions of our release procedure Wiki page here, which I just did.

@HEdingfield HEdingfield removed their assignment Jun 26, 2023
@yezr yezr removed the status in RCTab v2.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants