You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently (after Issue #57 / PR #660), the version number needs to be synced in three places:
Main.java
build.gradle
release.yml
Figure out a way to have just one place to update. Note the issues with version tagging: we prefer Main.java to allow version tags (e.g. -alpha), but jpackage on some platforms (at least Windows) will not allow non-canonical version numbers. It must be in the format a.b.c, not a.b.c-alpha. Figure out a solution. Some ideas:
Perhaps we use 0.0.0 as version numbers in builds?
Perhaps we no longer use -alpha?
Perhaps we use -alpha and accept that `jpackage will fail, and argue that this is okay because we don't want nicely packaged development builds that could be confused with official releases, especially if they have the same version number?
(I lean towards 3 or 1.)
The text was updated successfully, but these errors were encountered:
I think this was actually after issue #57 / PR #660?
Thanks for researching this! I definitely like option 3 best, since we shouldn't bother doing jpackage builds for alpha versions anyway, like you mentioned (the whole alpha thing is really just a CYA convention we put in place in case someone demands a mid-cycle build for some purpose, in which case we can just give them the jlinkZip output).
Barring an easy win here, it may be sufficient to just note all the spots in the release instructions of our release procedure Wiki page here, which I just did.
Currently (after Issue #57 / PR #660), the version number needs to be synced in three places:
Figure out a way to have just one place to update. Note the issues with version tagging: we prefer Main.java to allow version tags (e.g.
-alpha
), butjpackage
on some platforms (at least Windows) will not allow non-canonical version numbers. It must be in the format a.b.c, not a.b.c-alpha. Figure out a solution. Some ideas:-alpha
and accept that `jpackage will fail, and argue that this is okay because we don't want nicely packaged development builds that could be confused with official releases, especially if they have the same version number?(I lean towards 3 or 1.)
The text was updated successfully, but these errors were encountered: