Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when loading translations #889

Closed
matty0ung opened this issue Nov 20, 2024 · 1 comment · Fixed by #891
Closed

Errors when loading translations #889

matty0ung opened this issue Nov 20, 2024 · 1 comment · Fixed by #891

Comments

@matty0ung
Copy link
Contributor

matty0ung commented Nov 20, 2024

We currently have void Localization::loadTranslations() Error loading translations logged on many occasions. I think it's because we're not ensuring the Qt built-in translations are present. There are also some improvements we could make to the code that switches languages to make it a bit more robust.

Need to check also that the program correctly picks up the localised decimal separator when you override the default language, eg "1.070 sg" in the UK = "1,070 sg" in France.

(There is a separate issue that you need to close and reopen the program after you change language in order for everything to get updated. We'll hold off trying to fix that for now as it's quite a bit of work and most people don't change the language very often.)

@matty0ung matty0ung changed the title Wrong decimal separator Improve translation etc loading Nov 22, 2024
@matty0ung matty0ung changed the title Improve translation etc loading Erros when loading translations Nov 22, 2024
@matty0ung matty0ung changed the title Erros when loading translations Errors when loading translations Nov 22, 2024
@matty0ung
Copy link
Contributor Author

Fixed in 4.0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant