Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash changing fermentation duration #785

Closed
grahamrow opened this issue Jan 9, 2024 · 4 comments
Closed

Crash changing fermentation duration #785

grahamrow opened this issue Jan 9, 2024 · 4 comments

Comments

@grahamrow
Copy link

Hello! Enjoying running BrewTarget 3.0.10 on macOS 13.6.3 (22G436). When trying to change any of the fermentation times in the "Extras" tab of a recipe yields a crash with the following error after the SmartField contents are modified (via tab, enter, etc.):

[15:14:09.864] (1dvisj7kow) ERROR : ASSERT: "!std::holds_alternative<NonPhysicalQuantity>(*this->pimpl->m_typeInfo->fieldType)" in file ../src/widgets/SmartField.cpp, line 404 [widgets/SmartField.cpp:404]

This doesn't appear to happen with temperatures or other fields with units, only the times which appear to lack a unit specification. Happy to help debug further, and greatly appreciate your time and effort!

@matty0ung
Copy link
Contributor

Glad you're enjoying the software.
Thanks for the detailed report on the bug. I've just tried it on my local copy and get the same problem. I'll have a look at the relevant bit of the code...

matty0ung pushed a commit to matty0ung/brewtarget that referenced this issue Jan 9, 2024
@matty0ung matty0ung changed the title Crash on macOS 3.0.10 changing fermentation information Crash changing fermentation duration Jan 9, 2024
@dschwilk
Copy link

dschwilk commented Feb 3, 2024

That commit fixes this for me now on 3.0.11 build

@matty0ung
Copy link
Contributor

@grahamrow
Copy link
Author

Works great, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants