Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags in language selection #675

Closed
penguinpee opened this issue Oct 28, 2022 · 2 comments
Closed

Flags in language selection #675

penguinpee opened this issue Oct 28, 2022 · 2 comments

Comments

@penguinpee
Copy link
Contributor

I just updated brewtarget to 3.0.2 for Fedora. I adopted the package after is was orphaned as a hobby project.

Clicking through the software as a very low level smoke test, I noticed some flags are missing in the language selection. These are:

  • Estonian
  • Basque
  • Galician
  • Hungarian
  • Latvian
  • Serbian
  • Turkish

Moreover, flags are displayed in a square shape, making some of them look odd. The Danish flag i.e. looks like an inverted Swiss flag.

brewtarget_language_flags
@matty0ung
Copy link
Contributor

Hmm, yes, good point. It looks like 2:3 is the most usual ratio for flags (https://en.wikipedia.org/wiki/List_of_aspect_ratios_of_national_flags). Hopefully this is an easy fix. I'll have a look.

@matty0ung matty0ung mentioned this issue Oct 29, 2022
Merged
@matty0ung
Copy link
Contributor

Fixed in 3.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matty0ung @penguinpee