Importing an XML file from our export throws a lot of warnings #475
Comments
mikfire
added a commit
to mikfire/brewtarget
that referenced
this issue
Sep 10, 2020
Importing an XML that we exported threw errors. Imagine my embarrassment. One significant issue was when dealing with attributes that we store in memory as an enumerated type, but translate to a string when writing it to XML (or the database). Like hop.use and hop.useString. TableSchema::propertyToXml() searched only by the name of the property name (useString in this example) and not the key in the Map. This is fixed. Another issue was some misspellings in the schema files that prevented the import to find the right type. These have been fixed, and should have no impact on anybody. I also rearranged the interactions a little. Popping a QMessage box for every mashstep that we couldn't figure out was annoying. Now it warns on the console. The final fix was that I realized the default_database.sqlite had a bad schema for brewnotes and did not have the notes column defined. I am fairly certain this shouldn't have hurt anybody, as there was no code written to actually drop the column.
mikfire
added a commit
that referenced
this issue
Sep 11, 2020
Importing an XML that we exported threw errors. Imagine my embarrassment. One significant issue was when dealing with attributes that we store in memory as an enumerated type, but translate to a string when writing it to XML (or the database). Like hop.use and hop.useString. TableSchema::propertyToXml() searched only by the name of the property name (useString in this example) and not the key in the Map. This is fixed. Another issue was some misspellings in the schema files that prevented the import to find the right type. These have been fixed, and should have no impact on anybody. I also rearranged the interactions a little. Popping a QMessage box for every mashstep that we couldn't figure out was annoying. Now it warns on the console. The final fix was that I realized the default_database.sqlite had a bad schema for brewnotes and did not have the notes column defined. I am fairly certain this shouldn't have hurt anybody, as there was no code written to actually drop the column.
|
Closed by commit dee75b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a side effect of the most recent rewrite of the database code I did. Unless it is an enumerated type, we write the property to the database as is. With the enumerated types, converting the property name to the XML property name isn't working.
I have a fix, but need to address some other issues before I can make a clean PR.
The text was updated successfully, but these errors were encountered: