Broken unit tests after #453

[cgspeck]

Firstly I want to say a massive thank you for your work on this. Brewtarget is the only local brewing software worth using and I use it for all of my brews.

PR #453 appears to have fixed issues where scaling up recipes, and editing quantities in tables were not being saved however it has broken the unit tests:

mkdir brewtarget-build
cd brewtarget-build/
cmake ../brewtarget-upstream/
...
make
...
08:43 $ make test                                                               
Running tests...                                                               
Test project /home/chris/src/brewtarget-build                                 
    Start 1: pstdintTest                                               
1/3 Test #1: pstdintTest ......................***Exception: Child aborted  0.61 sec
    Start 2: recipeCalcTest_allGrain                                              
2/3 Test #2: recipeCalcTest_allGrain ..........***Exception: Child aborted  0.36 sec 
    Start 3: postBoilLossOgTest                                              
3/3 Test #3: postBoilLossOgTest ...............***Exception: Child aborted  0.36 sec  
                                                                            
0% tests passed, 3 tests failed out of 3                                                          
                                                                                     
Total Test time (real) =   1.33 sec                                        
                                                                               
The following tests FAILED:                                                 
          1 - pstdintTest (Child aborted)                                      
          2 - recipeCalcTest_allGrain (Child aborted)                          
          3 - postBoilLossOgTest (Child aborted)                                     
Errors while running CTest                                                                                    
Makefile:151: recipe for target 'test' failed                                 
make: *** [test] Error 8                                                        
✘-2 ~/src/brewtarget-build

My CI/CD build caught this error here.

[mattiasmaahl]

Is this still an issue?

[mikfire]

Shouldn't be. It was fixed with the shown merge.