Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ingredient from the recipe does not update calculated beer parameters #341

Closed
eltomek opened this issue Jan 21, 2017 · 2 comments · Fixed by #389
Closed

Removing ingredient from the recipe does not update calculated beer parameters #341

eltomek opened this issue Jan 21, 2017 · 2 comments · Fixed by #389

Comments

@eltomek
Copy link
Contributor

eltomek commented Jan 21, 2017

The easiest scenario on hop example (the same works for any ingredient that impacts beer parameter calculations):

  1. add some hop item to the recipe, it will get added with 0,0 mass amount
  2. change the amount to e.g 100g and see the IBU changed on the recipe details
  3. remove the hop you just added and observe that the IBU did not change (issue).

There are 2 actions that update the beer recipe calculations:

  1. changing the parameters of any ingredient entry in the recipe (on the hop example you can change the Amount or Use values). So if you remove the hop entry the IBU will not change, but if you just update any other ingredient on the recipe the calculations will update
  2. dragging and dripping new ingredient from the let hand side BtTreeView.
@eltomek eltomek changed the title Removing an ingredient from the recipe does not update calculated beer parameters Removing ingredient from the recipe does not update calculated beer parameters Jan 21, 2017
@jawsdaws
Copy link
Contributor

Removing fermentables and removing yeast also have the same problem. I think I have a fix. I need to do more testing...

@jawsdaws
Copy link
Contributor

This appears to be a bug in 2.4.0 and not in 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants