Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Correction not working #61

Open
turboPasqual opened this issue Jun 25, 2024 · 1 comment
Open

Output Correction not working #61

turboPasqual opened this issue Jun 25, 2024 · 1 comment

Comments

@turboPasqual
Copy link

Hi. I noticed that the output correction is not working. Neither for the universe nor for the channels.
So I dug deep into the rabbithole and was able to find the 2 underlying problems which can be solved very easily:

In light.py you use this code for the output correction:

universe.output_correction = AVAILABLE_CORRECTIONS.get( universe_cfg[CONF_OUTPUT_CORRECTION] ) ... d.channel.output_correction = AVAILABLE_CORRECTIONS.get( device[CONF_OUTPUT_CORRECTION] )

The correct code for this would be:
universe.set_output_correction(AVAILABLE_CORRECTIONS.get( universe_cfg[CONF_OUTPUT_CORRECTION] )) ... d.channel.set_output_correction(AVAILABLE_CORRECTIONS.get( device[CONF_OUTPUT_CORRECTION] ))

The second problem is probably also quite easy to fix but I am not very good with python. The problem ist the second part of the upper code where you set a correction for the channel. This is alsways set even if did not put it in your homeassistant configuration. So if you put an output correction of e.g quadratic for the universe and don't put any output correction for the channel, it will be set to linear no matter what.

@robinbervoets
Copy link

Hello @Breina any plan to work on this topic ? Linear dimming is just the worst thing to do in most cases:

actual visual brightness changes drastically for smaller changes in lower % range (e.g. 10% → 20%)
changes barely for larger changes in upper % range (e.g. 60% → 100%)
Many credits for your great integration, is working perfectly, just missing the possibility to use other output corrections …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants