Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

[Feature Request]: Can the streaming/audio switches have unique names? #534

Open
pgib opened this issue Dec 24, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@pgib
Copy link

pgib commented Dec 24, 2022

Enhancement of issue

The accessories for streamingSwitch and audioSwitch don't seem to label themselves uniquely. (Not sure if this is the Hope app doing this or not.) As a result, it's impossible to tell which switch does what.

IMG_14878438E32D-1

Solution

Is there any way to prefix these labels with the type?

Alternatives

No response

Additional Context

No response

@pgib pgib added the enhancement New feature or request label Dec 24, 2022
@getaaron
Copy link

It looks like the name is being passed through when creating the accessory service

? this.accessory.addService(
serviceType,
`${this.accessory.displayName} ${name}`,
`${this.accessory.displayName} ${name}`,
)

(In this case, I believe this.accessory.displayName is Driveway in your example and name can be Announcements, Streaming, etc.)

I wonder if the helpful part is getting truncated due to length

@Brandawg93 what do you think about using only name as the service's display name (and keeping this.accessory.displayName as the ID for deduplication purposes)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants