@nestjs/swagger ApiProperty not required on Entity classes

[aschnebelext]

The auto-generated entity classes are for internal use only, correct?

I would not assume that such classes are annotated in such a case.

But this is currently generated.

[Brakebein]

The original package had only the ConnectDTO, CreateDTO, UpdateDTO, and Entity classes. We were adding the plain DTO later, because you usually don't return all the relations of a model. And the Entity classes have, due to their relations, potentially a lot of circular dependencies. That's maybe why both the plain DTO and the Entity classes are annotated.

We actually still use some of the Entity classes as response type in our project. Because if you want to return an entity with only some nested relations, you would still have to define some extra DTOs. After some fast initial implemention in our project, we wanted to replace them, but haven't done it yet.

I haven't seen it yet from the perspective that the Entity classes should only be intended for internal use. It basically makes sense, in particular that you don't want these circular dependencies (leads to some trouble with the generated API docs). But changing this would also mean a breaking change of the package.

I guess you find that the current version generates too much (unused) extra lines of code you have to commit in your project?