Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direction 0 elements get plotted with a squished arrow #14

Open
barrel0luck opened this issue Dec 3, 2024 · 1 comment
Open

Direction 0 elements get plotted with a squished arrow #14

barrel0luck opened this issue Dec 3, 2024 · 1 comment

Comments

@barrel0luck
Copy link

barrel0luck commented Dec 3, 2024

I know you are not actively maintaining this package.
As it is the best package available to plot plasmids in R, I'm opening some issues/ feature requests for when you find the time/ inspiration to work on it.

Issue:
When I try to plot direction 0 features, I get a line on one side of the feature. It's like the arrow was supposed to be drawn but it hit a wall and got squished. It can be fixed in Inkscape, but it is a bit tricky.

library(tidyverse)
library(plasmapR)

pTEST <- read_tsv("pTEST.txt", skip = 2)
pTEST_plot <- plot_plasmid(pTEST, name = "pTEST")
ggsave("pTEST_4in.svg", pTEST_plot, width = 4, height = 4)
ggsave("pTEST_7in.svg", pTEST_plot, width = 7, height = 7)


pTEST_7in

[
pTEST.txt
](url)

@BradyAJohnston
Copy link
Owner

Thanks for the interest in the package!

This isn't something I can get to until likely next year, but it is something on my radar. I got 90% through an internal re-write to creating geom_* functions like geom_feature_arrow() so that there could be a single function that plots everything, or the users could use individual functions to build a custom plot.

I think all of the features you've raised are reasonable and achievable, and I've gotten interest and emails from others as well so I'll return to this package hopefully sometime soon and do some polishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants