Space characters removed from bot names 🙀

[artkirienko]

Hi @jkivilin @Bots-United! Thanks for your great work! 🎉

jk_botti_names.txt

Screenshots

Versions and configs

jk_botti version 1.43

• HLDS Build 7882.

  Protocol version 47/48
  Exe version 1.1.2.2/Stdio (valve)
  Exe build: 17:23:32 May 24 2018 (7882)
  

• Metamod-p version 1.21p38

• AMX Mod X version 1.8.2

Available as a Docker Image here: https://github.com/artkirienko/hlds-docker-dproto

[josemam]

You might be interested to know that this behaviour is inherited from the HPB-Bot template 4. Nevertheless, it has been worked around in at least one bot based on it: FoxBot bots do keep spaces in their names. So this is probably fixable.

[artkirienko]

@josemam long story short, bot name format is being checked and fixed in two places: when reading names from file and when creating bot. I’ve just commented out both of these checks and rebuilt jk_botti for my server, so it supports now bot names with spaces included.

I’m not sure if it is the best solution.

Do jk_botti need to check input for bot names or game server admin needs to be responsible for correct bot names?

[josemam]

I have no clue on that, but I guess that the code performs other, necessary checks (e.g. for characters like é ñ ç) and only the space trimming can (probably) be safely removed.

You (we) should get advice from someone that has actually worked on bots and/or the HL engine in order to be sure on what to do here. Maybe the members of Bots-United can help.

[Vladsmesh]

How many lines in jk_botti_names does the plugin support? I have written more than 300 names for bots, but it seems that no more than 20 are used.