fix: add a default value to subtitle and add validation for subtitle …

…type
Botfuel · Nov 20, 2018 · fefdcb2 · fefdcb2
1 parent 1d7103b
commit fefdcb2
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/botfuel-dialog/src/messages/card.js b/packages/botfuel-dialog/src/messages/card.js
@@ -29,7 +29,7 @@ class Card extends Part {
    * @param {Object[]} actions - an array of actions
    * @param {Object} [subtitle] - the subtitle (optional)
    */
-  constructor(title, imageUrl, actions, subtitle) {
+  constructor(title, imageUrl, actions, subtitle = '') {
     super();
     this.title = title;
     this.imageUrl = imageUrl;
@@ -40,19 +40,23 @@ class Card extends Part {
   /** @inheritDoc */
   toJson() {
     // TODO : this is very Messenger specific, let's generalize it!
-    return {
+    const cardJson = {
       title: this.title,
       image_url: this.imageUrl,
-      subtitle: this.subtitle,
       buttons: this.actions.map(action => action.toJson())
     };
+    if (this.subtitle !== '') {
+      cardJson.subtitle = this.subtitle
+    }
+    return cardJson
   }
 
   /** @inheritDoc */
   validate() {
     this.validateString('card', this.title);
     this.validateUrl('card', this.imageUrl);
     this.validateActions('card', this.actions);
+    this.validateString('card', this.subtitle)
   }
 
   /**