Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --mode to --library #58

Closed
Tracked by #85
nsyzrantsev opened this issue May 12, 2024 · 0 comments · Fixed by #101
Closed
Tracked by #85

Rename --mode to --library #58

nsyzrantsev opened this issue May 12, 2024 · 0 comments · Fixed by #101

Comments

@nsyzrantsev
Copy link
Collaborator

nsyzrantsev commented May 12, 2024

The --mode <rnaseq/amplicon> falg should be renamed to --library <rnaseq/amplicon>.

Also don't forget to fix a nextflow.config:

pyigmap/nextflow.config

Lines 62 to 90 in 1f1df84

def getFiltersList() {
def filtersList = []
if (params.remove_chimeras) {
filtersList << "--remove-chimeras"
}
if (params.fq1_barcode_pattern == null && params.fq2_barcode_pattern == null) {
filtersList << "--top-c-call --top-v-alignment-call"
}
if (params.only_best_alignment) {
filtersList << "--only-best-alignment"
}
if (params.discard_junctions_with_N) {
filtersList << "--discard-junctions-with-N"
}
if (params.fq1_barcode_pattern != null || params.fq2_barcode_pattern != null) {
filtersList << "--skip-pgen-calculation"
} else if (params.filter_pgen_all != null) {
filtersList << "--filter-pgen-all ${params.filter_pgen_all}"
} else {
filtersList << "--filter-pgen-singletons ${params.filter_pgen_singletons}"
}
return filtersList
}

@nsyzrantsev nsyzrantsev changed the title Make --mode rnaseq as default Remove logic with --mode in main.nf May 12, 2024
@nsyzrantsev nsyzrantsev changed the title Remove logic with --mode in main.nf Rewrite logic with --mode in main.nf May 12, 2024
@nsyzrantsev nsyzrantsev changed the title Rewrite logic with --mode in main.nf Change --mode -> --library Jun 20, 2024
@nsyzrantsev nsyzrantsev changed the title Change --mode -> --library Rename --mode to --library Jun 20, 2024
@nsyzrantsev nsyzrantsev self-assigned this Jun 20, 2024
@nsyzrantsev nsyzrantsev linked a pull request Jun 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant