Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump gdk #390

Merged
merged 3 commits into from
Feb 17, 2025
Merged

chore: bump gdk #390

merged 3 commits into from
Feb 17, 2025

Conversation

jackstar12
Copy link
Member

No description provided.

Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? Last time we updated GDK, the wallet broke

@jackstar12
Copy link
Member Author

Did you test this? Last time we updated GDK, the wallet broke

Last update broke because of the incorrect max inputs that were imposed, which are now fixed:
Blockstream/gdk@2e53b69

We can also remove the fee floor in our implementation since its implemented in gdk properly now:
Blockstream/gdk@1fe1f3b

https://github.com/Blockstream/gdk/blob/196340427e061fa9b8f8012672d566b70b8c393c/CHANGELOG.md?plain=1#L79-L80

@jackstar12
Copy link
Member Author

Just did a local run of the auto consolidation test with 256 inputs

@michael1011 michael1011 merged commit 26d6f86 into master Feb 17, 2025
1 check passed
@michael1011 michael1011 deleted the chore/bump-gdk branch February 17, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants