Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use discountCT #318

Merged
merged 7 commits into from
Feb 13, 2025
Merged

feat: use discountCT #318

merged 7 commits into from
Feb 13, 2025

Conversation

jackstar12
Copy link
Member

@jackstar12 jackstar12 commented Oct 20, 2024 •
edited
Loading

Adds support for discount ct and removes all lowball related code.
Only to be merged once discountct is widely deployed on mainnet

@jackstar12 jackstar12 force-pushed the feat/discountct branch 2 times, most recently from 4adfa55 to 6c8491e Compare October 23, 2024 12:44
@michael1011 michael1011 changed the title feat: use discountct feat: use discountCT Nov 3, 2024
@michael1011
Copy link
Member

Needs changes for https://github.com/BoltzExchange/boltz-client/pull/361/files#diff-99bb9a4912420ebe5772b4e827280df5a010942ef20ef8d8b09da8961b81ad07R372

@jackstar12 jackstar12 force-pushed the feat/discountct branch 5 times, most recently from 934a3e5 to 9d5b434 Compare January 7, 2025 17:53
@jackstar12 jackstar12 force-pushed the feat/discountct branch 2 times, most recently from 4e988de to 52e9494 Compare January 22, 2025 13:46
michael1011
michael1011 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also remove the lowball workarounds in the Liquid wallet, like setting TransactionInputs?

@jackstar12 jackstar12 force-pushed the feat/discountct branch 2 times, most recently from 8d029a6 to f760e88 Compare January 22, 2025 14:46
@kilrau
Copy link
Member

kilrau commented Jan 22, 2025

I am a bit worried this will brick sth for the BTCPay Plugin so maybe let's go with a manua/preview release of the plugin first

@jackstar12 jackstar12 force-pushed the feat/discountct branch 2 times, most recently from 517969a to 107c59f Compare February 3, 2025 14:09
michael1011
michael1011 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK but needs testing on testnet. I'd like to ship that when mainnet switches to discount

@michael1011 michael1011 merged commit 71b97a5 into master Feb 13, 2025
3 checks passed
@michael1011 michael1011 deleted the feat/discountct branch February 13, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael1011 michael1011 michael1011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackstar12 @michael1011 @kilrau