fix: remove duplicated labels on rbac components

[rafaribe]

I was trying to use your operator with FluxCD and noticed that the RBAC components already have the following labels defined in cloudflare-zero-trust-operator.labels.

• app.kubernetes.io/instance
• app.kubernetes.io/managed-by
• app.kubernetes.io/name

Therefore when the chart is rendered, there's duplication of labels.
This makes it impossible to use with FluxCD due to #283.

Thank you in advance!

[jzweifel]

❤️

[BojanZelic]

Thanks for the contribution! 🎉

Couple of points:

First, The files in helm/cloudflare-zero-trust-operator/templates are auto-generated based on the kustomize manifests, so if I merge this as-is it won't work, since it will just be overwritten; operator-sdk generates the rbac kustomize manifests based off kubebuilder annotations so I'd like to keep the single source of truth;

take a look at https://github.com/BojanZelic/cloudflare-zero-trust-operator/blob/main/Makefile#L213-L221 to see how the helm template is created; We could possibly use yq or sed (or if you have any other ideas) here in the makefile to remove the labels;

you should be able to make helm locally to verify it; This command gets ran every time a release is made;

Second, there's no need to update the chart version; it's automatically handled when we tag & build a release: https://github.com/BojanZelic/cloudflare-zero-trust-operator/blob/main/.github/workflows/perform-release.yaml#L31

Let me know how it goes! I can also take a look later in the week if there are any issues;

[rafaribe]

I've pushed a new commit that should address the things you mentioned. I force-pushed it to not clutter the main repo with the previous approach.
Take a look when you can and let me know how it goes :)