Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unfiltered datasets, selected dataset and filter state information through arguments-from-module-manager #15

Open
ml-ebs-ext opened this issue Oct 3, 2024 · 0 comments

Comments

@ml-ebs-ext
Copy link
Contributor

The current filtering behavior in dv.manager fits the needs of most of our modules, but some of them could benefit from more customized filtering behaviors. Those could be easily achieved by having dv.manager provide modules with some extra knowledge on the data it is provided and the state of dv.filter.

Would it be possible to extend this list with ...?

  • unfiltered_datasets: Non-reactive named list of datasets provided to dv.manager.
  • selected_dataset: Reactive list with these two elements:
    • name: character(1) identifying the selected dataset
    • filter_mask: logical(n) identifying the records of the selected dataset that pass the criteria selected in dv.filter.

The non-reactive nature of unfiltered_datasets could allow, among other things to perform checks or populate menus prior to reactive time.
The batching of the two selected_dataset elements inside a single reactive would ensure the atomicity of the information and avoid modules receiving desynchronized name+mask information.

This information is readily available in dv.manager so no significant extra processing would be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant