Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include compiled params.yaml in git repo #7

Closed
grst opened this issue Aug 22, 2024 · 0 comments · Fixed by #36
Closed

Do not include compiled params.yaml in git repo #7

grst opened this issue Aug 22, 2024 · 0 comments · Fixed by #36

Comments

@grst
Copy link
Collaborator

grst commented Aug 22, 2024

Pro

The file is automatically generated. Automatically generated filese are typically not included in a git repo
It adds noise to code-review and diffs

Con

the compiled configuration is frozen and reproducible in each commit (dso tooling might change over time and config files might compile different in the future - not expecting anything here, but what if a bug is found in the library that resolves the configs)
you can run the project without the dso helper using plain dvc. 

We initially decided to keep params.yaml checked into git, but there are also good reasons not to. Let's try it out in one of the projects and see if it has any other unintended side effects. 


Another issue with this setup is that

dvc pull

after an initial clone will fail unless

dso compile-config

is run first.


dso compile-config hook should run on post-checkout before dso checkout in that case


If we do that, I'd like to freeze the dso version for each project. Here's an idea how to do that: github.com//issues/6

@grst grst mentioned this issue Oct 18, 2024
@grst grst closed this as completed in #36 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant