Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile config: null doesn't overwrite parameter in params.yaml #12

Closed
grst opened this issue Aug 22, 2024 · 4 comments · Fixed by #45
Closed

compile config: null doesn't overwrite parameter in params.yaml #12

grst opened this issue Aug 22, 2024 · 4 comments · Fixed by #45

Comments

@grst
Copy link
Collaborator

grst commented Aug 22, 2024

It has been noted that setting a parameter in the params.in.yaml to null doesn't overwrite the same parameter in the params.yaml:

params.in.yaml

dso:
quarto:
   watermark:
     text: null
     testing: 2

params.yaml

    watermark:
     text: NOT QCed
     testing: 2

-> This needs to be fixed/adapted in hiyapyco

@grst
Copy link
Collaborator Author

grst commented Sep 30, 2024

Also contribute changes back to Hiyapyco

@grst
Copy link
Collaborator Author

grst commented Oct 1, 2024

Attempted to address this upstream in zerwes/hiyapyco#78

@grst
Copy link
Collaborator Author

grst commented Oct 18, 2024

Depends on upstream release then we can "unvendor" this.

@grst
Copy link
Collaborator Author

grst commented Oct 21, 2024

v0.7 is there

@grst grst mentioned this issue Nov 4, 2024
@grst grst closed this as completed in #45 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant