Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return API and scanner versions in the json inventory #639

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

demeringo
Copy link
Collaborator

Closes #265 by adding metadata to the inventory output in json format.

{
  "metadata": {
    "estimation_date": "2024-12-14T22:47:25.783194010Z",
    "description": "Estimation using Boavizta API",
    "cloud_scanner_version": "3.2.0",
    "boavizta_api_version": "1.3.6",
    "execution_statistics": {
      "inventory_duration": {
        "secs": 0,
        "nanos": 296360816
      },
      "impact_estimation_duration": {
        "secs": 0,
        "nanos": 1937
      },
      "total_duration": {
        "secs": 0,
        "nanos": 296362753
      }
    }
  },
  "impacting_resources": []
}

@demeringo demeringo linked an issue Dec 14, 2024 that may be closed by this pull request
@demeringo demeringo added this to the 3.2.0 milestone Dec 14, 2024
@demeringo
Copy link
Collaborator Author

demeringo commented Dec 14, 2024

@jnioche @damienfernandes I want to highlight that it slightly modifies the format of the json output for the estimations (Not the format of the data itselft but it adds a metadata section in the output).

No changes on the metrics output. If implemented later it will be tracked in #266.

@demeringo demeringo merged commit 0b3cbf8 into main Dec 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return API and scanner version in the json output
1 participant