Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to BoaviztAPI 1.3.3 #633

Closed
jnioche opened this issue Dec 10, 2024 · 7 comments · Fixed by #638
Closed

Upgrade to BoaviztAPI 1.3.3 #633

jnioche opened this issue Dec 10, 2024 · 7 comments · Fixed by #638
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@jnioche
Copy link
Collaborator

jnioche commented Dec 10, 2024

https://github.com/Boavizta/boaviztapi/

@jnioche jnioche added the dependencies Pull requests that update a dependency file label Dec 10, 2024
@jnioche jnioche added this to the 3.2.0 milestone Dec 10, 2024
@demeringo
Copy link
Collaborator

We need to check with @da-ekchajzer if there were breaking changes in the API routes / parameters related to cloud (in which case we may have to regenerate a SDK).

Otherwise (if the change is only internal to the API or data returned) we should be able to swap it directly (in docker compose).

@jnioche
Copy link
Collaborator Author

jnioche commented Dec 10, 2024

Agreed. I would hope that the version number change reflects that the new version does not contain anything breaking. My initial tests with the latest image seem to show that it is running fine

@da-ekchajzer
Copy link
Collaborator

For information, the worklfow that was supposed to generate the sdk didn't succeed because benoit's email associated with pypi doesn't have the MFA. And because I'm stupid I deleted the workflow.

@da-ekchajzer
Copy link
Collaborator

But their shouldn't be any breaking changes

@da-ekchajzer
Copy link
Collaborator

I just added a router: http://api.boavizta.org/v1/utils/version as requested by @demeringo

@demeringo
Copy link
Collaborator

Cool, thank you @da-ekchajzer.

@jnioche I should be able to update and publish the API SDK today and show API version in cloud scanner outputs(see #266 #265) before end of week. But if you prefer to release a version of cloud scanner right now, without waiting for this, no problem (Current cloud scanner tests pass when targetting the latest API).

@jnioche
Copy link
Collaborator Author

jnioche commented Dec 11, 2024

@demeringo no rush, we might as well include the API versions in the next release

@demeringo demeringo linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants