-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add retries to polling functionality #43
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 96.93% 95.90% -1.03%
==========================================
Files 3 3
Lines 163 171 +8
Branches 10 11 +1
==========================================
+ Hits 158 164 +6
- Misses 2 4 +2
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I believe we may also needs to add loggers: [] to the manifest for HA? |
👍
|
Sounds good - when you're okay with me merging this in, I'll do so then I'll make a small PR to bump the version and add loggers to manifest Let me know if there is anywhere else you think logs would be helpful for debugging |
Not sure if we should call this a fix or a new feature. Probably fine either way |
I think calling it a fix is fine here since it doesn't add new states, it only makes it less likely to fail. |
Tested all good 👍 |
Perfect, thanks @bdraco |
this PR does two things
adds a few extra logs to help debug Oral-B Since update Bluetooth blinks random during session home-assistant/core#88009
potentially I am being silly here, but I think the code to get payloads was problematic, as if it failed, it would still attempt to get it as it was outside of the try catch and after finally.
I don't know if the except BleakError is worth it, as I know the connector also excepts for bleakerrors.