Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: io4 identification for some models #38

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Feb 2, 2023

Add additional IO4 model bytes

@Lash-L
Copy link
Collaborator Author

Lash-L commented Feb 2, 2023

Will fix it all later, just wanted to get it started so it was on my github and I could remember to do it

src/oralb_ble/parser.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 96.91% // Head: 96.91% // No change to project coverage 👍

Coverage data is based on head (a343ccf) compared to base (4419547).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files           3        3           
  Lines         162      162           
  Branches       10       10           
=======================================
  Hits          157      157           
  Misses          2        2           
  Partials        3        3           
Impacted Files Coverage Δ
src/oralb_ble/parser.py 96.06% <ø> (ø)
src/oralb_ble/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Feb 3, 2023

@bdraco good now

@bdraco bdraco changed the title fix: fixed io4 identification fix: fixed io4 identification for some models Feb 3, 2023
@bdraco bdraco changed the title fix: fixed io4 identification for some models fix: io4 identification for some models Feb 3, 2023
@bdraco bdraco merged commit 2eaaf2b into Bluetooth-Devices:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants