-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework sectors, fix pressures, and fix misidentification of IO 9 as 8 #30
Conversation
added pressures for 122,182, and 186 relating to buttons
sectors are not what sector of your mouth the brush is in, but rather what time sector you are in, first, second, third, or forth 30 second sector
due to incorrect identifying one as the other, until we have more data, both models should be grouped
not a real state, but will be useful as an alternative to 'unknown'
Codecov ReportBase: 95.78% // Head: 95.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 95.78% 95.91% +0.12%
==========================================
Files 2 2
Lines 95 98 +3
Branches 6 7 +1
==========================================
+ Hits 91 94 +3
Misses 2 2
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This has been a good introduction for me into the world of BLE. I'd like to start understanding development for HA, if you have a second, I'd appreciate you tell me if my steps are correct. |
this code should run as long as brush is not running
That sounds like a reasonable path to me. Be sure to link the docs changes in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. For future PRs it would be nicer to split feat
and fix
commits into separate PRs
Heard. Will make sure to do so in the future |
Also since you are making significant changes you should add yourself to codeowners for the integration in HA https://github.com/home-assistant/architecture/blob/master/adr/0008-code-owners.md |
Okay this one is kind of spread out. I tired to make sure lint wont get made at me, but we will see.
Pressures
Sectors
a successful brushing session.
Io 8/9
Offline State for io series
bluetooth.async_track_unavailable
may be the solution in home assistant. Once the device goes unavailable - set all of the states to 'offline' or 0 or something similar. This offline state just allows that functionality to happen as there will be a state that can be set. I haven't even attempted this(but I plan to try) because developing on core seems like it will be a challenge, so I am not sure if it is a real solution, but I thought I would add in the functionality that is needed here, as it wont cause any kinds of issues.