From e8c300b9c550a6eeb5c54d60d3e98e01de5ab9be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaquier=20Aur=C3=A9lien=20Tristan?= Date: Wed, 17 Jul 2024 15:12:35 +0200 Subject: [PATCH 1/3] decay_time_constant_after_stim default on failing is None and not -1 anymore --- emodelrunner/factsheets/physiology_features.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/emodelrunner/factsheets/physiology_features.py b/emodelrunner/factsheets/physiology_features.py index bf0be5e..9bcd29d 100644 --- a/emodelrunner/factsheets/physiology_features.py +++ b/emodelrunner/factsheets/physiology_features.py @@ -50,7 +50,8 @@ def extract_physiology_features( ) voltage_base = efel_results[0]["voltage_base"][0] - dct = efel_results[0]["decay_time_constant_after_stim"][0] + dct = efel_results[0]["decay_time_constant_after_stim"] + dct = dct[0] if dct is not None else dct trace["decay_start_after_stim"] = efel_results[0]["voltage_base"] trace["stimulus_current"] = [current_amplitude] From e4c4bb8f2a9b61329ffe387ab0da3800f1ace6b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaquier=20Aur=C3=A9lien=20Tristan?= Date: Wed, 17 Jul 2024 15:31:57 +0200 Subject: [PATCH 2/3] also ohmic_input_resistance_vb_ssse can be None now, taking that into account --- emodelrunner/factsheets/physiology_features.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/emodelrunner/factsheets/physiology_features.py b/emodelrunner/factsheets/physiology_features.py index 9bcd29d..036f4ed 100644 --- a/emodelrunner/factsheets/physiology_features.py +++ b/emodelrunner/factsheets/physiology_features.py @@ -57,7 +57,8 @@ def extract_physiology_features( trace["stimulus_current"] = [current_amplitude] efel_results = efel.getFeatureValues([trace], ["ohmic_input_resistance_vb_ssse"]) - input_resistance = efel_results[0]["ohmic_input_resistance_vb_ssse"][0] + input_resistance = efel_results[0]["ohmic_input_resistance_vb_ssse"] + input_resistance = input_resistance[0] if input_resistance is not None else input_resistance return [voltage_base, input_resistance, dct] From 44691a55f0c1580c1a39c58193426e59b837bc97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaquier=20Aur=C3=A9lien=20Tristan?= Date: Wed, 17 Jul 2024 15:54:45 +0200 Subject: [PATCH 3/3] black fix --- emodelrunner/factsheets/physiology_features.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/emodelrunner/factsheets/physiology_features.py b/emodelrunner/factsheets/physiology_features.py index 036f4ed..4e1f834 100644 --- a/emodelrunner/factsheets/physiology_features.py +++ b/emodelrunner/factsheets/physiology_features.py @@ -58,7 +58,9 @@ def extract_physiology_features( efel_results = efel.getFeatureValues([trace], ["ohmic_input_resistance_vb_ssse"]) input_resistance = efel_results[0]["ohmic_input_resistance_vb_ssse"] - input_resistance = input_resistance[0] if input_resistance is not None else input_resistance + input_resistance = ( + input_resistance[0] if input_resistance is not None else input_resistance + ) return [voltage_base, input_resistance, dct]