Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to master crashes node. #464

Closed
roeierez opened this issue Jun 10, 2024 · 5 comments
Closed

Upgrade to master crashes node. #464

roeierez opened this issue Jun 10, 2024 · 5 comments
Assignees
@cdecker
Labels
state::fixed This issue was addressed in a PR and will be closed once it is merged state::verifying

Comments

@roeierez
Copy link
Contributor

On first run when upgrading to master the node crashes.
Seems like it is a result of signer upgrade.
@cdecker
Copy link
Collaborator

cdecker commented Jun 10, 2024

From what I can tell this is related to maybe_upgrade not completing before the node gets scheduled, causing the old version to be started, which doesn't match with the signer version, which then causes the crash. I'll dig into this further

@cdecker cdecker self-assigned this Jun 10, 2024
@roeierez
Copy link
Contributor Author

Thanks. Perhaps also worth also stopping the node right after maybe_upgrade (in case of real upgrade) because the node can be online at that time.

@cdecker
Copy link
Collaborator

cdecker commented Jun 10, 2024

Yep, that's the plan. Actually stopping would already be sufficient as it'd be immediately rescheduled by the client connecting 👍

@cdecker
Copy link
Collaborator

cdecker commented Jun 16, 2024

This has been merged and will be deployed on the server side tomorrow 👍

@cdecker cdecker added state::verifying state::fixed This issue was addressed in a PR and will be closed once it is merged labels Jun 16, 2024
@cdecker
Copy link
Collaborator

cdecker commented Jun 20, 2024

Confirmed that this is no longer an issue.

@cdecker cdecker closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdecker cdecker

Labels
state::fixed This issue was addressed in a PR and will be closed once it is merged state::verifying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdecker @roeierez