-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: 3500ish ms boot up time for js according to lighthouse #1399
Comments
@blockrazorbot claim |
Is nx meant to be used instead of Blaze? |
No we can still use and keep all of blaze html templates and helpers and hooks (the power of proxies). |
Although I'm unsure about the compilation steps, as in detecting that html that goes with a template, and bundling that. |
Ill wait for reply here nx-js/framework#15, or a sign of life or 10-15 days. @blockrazorbot label "unmet dependency". |
In the longer term, we can always fork it and maintain it ourselves, but it had better work really well to justify it. |
Not doing for prototype:
|
Blaze.toHTML(Template.mainLayout). Basically gives me what I want. |
Blaze has special template for body, which would be the root, and I have to parse dynamic template function too. |
try using react's compose to bind this to state for Template.instance(), and also apply arguments for template helpers. |
@blockrazorbot remove "unmet dependency" |
templatetag.js and codegen contain parsers in spacebars-compiler. templating-tools produces render function with html-scanner.js |
SpacebarsCompiler.parse(htmlString), gives me what I want, would've saved a couple or 3 hours, if I bothered with reading the api. |
This will take more like over 20 hours. I spend 8 hours on this, and you could fairly say that I got nowhere with 100 lines of empty code written (doesn't work, isn't very meaningful), and no way to get spacebars format that I want (in form of SpacebarsCompiler.parse(html string) at least on client, forget having it built by meteor. |
NX-framework doesn't have SSR, and I believe meteor's server-render definitely expects static-html for it's compiler instead of blaze compiler. |
I wouldn't mind giving it another stab only focusing on the small demo without bothering with the compiler, and then benchmarking that using mitar's benchmark repository. Which shouldn't be much different from simply comparing nx and blaze. |
@gazhayes I offered special terms for this which went along the lines of I can be paid up to 8 hours, and if I can't deliver I don't get paid, do I close this? |
What do you feel like doing? |
Im totally interested but would like to make money. |
Ok close it off. We can open this again later if it becomes 'interesting'. |
but it is. |
I'll implement Kadira to get some more data first. |
I belief kadira is for server. |
I'll go do a tracker conversion. If it works/helps I'm billing it. |
OK. That's fine with me. But it's best to keep an eye out for higher priority things (errors etc) and do this as a lower priority. |
|
I've decided that it's easier to map oberve-utils onto tracker.api rather than other way around. api:
|
Unsure if api behaviour is replicated:
|
There's limitation on manipulating reactiveVars in autorun. nx-js/observer-util#25 |
@blockrazorbot label 'unmet dependency' |
@blockrazorbot remove label "in progress" |
@blockrazorbot unlabel "in progress" |
Problem: It takes 4 seconds to init js alone according to lighthouse (albeit with some major offenders w/o which its 2secs). Benchmarks: https://github.com/mitar/meteor-web-rendering-framework-benchmark, by blaze maintainer.
Solution: Use nx-framework which is expandable and based on proxies (5% audience usage unsupported) to render things reactively without editing any of the templates, but is as unmaintained as blaze. My offer of trying this for halfway free stands. This will also enable SSR.
The text was updated successfully, but these errors were encountered: